[WIP](unique-key-merge-on-write) Add delete bitmap for DSIP-018 #10548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpfly
reviewed
Jul 1, 2022
| repeated string rowset_ids = 1; | ||
| repeated uint32 segment_ids = 2; | ||
| repeated int64 versions = 3; | ||
| repeated bytes segment_delete_bitmaps = 4; |
be/src/olap/tablet_meta.h
Outdated
| * "rowset id 1, segment id 1" is deleted/overitten by some loads at "version 2" | ||
| */ | ||
| class DeleteBitmap { | ||
| public: |
spaces-X
reviewed
Jul 4, 2022
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
hi @compiletheworld , please fix the BE code format |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
zhannngchen
reviewed
Jul 8, 2022
Contributor
|
@compiletheworld the formatter failed, pls fix it. |
compiletheworld
added a commit
to compiletheworld/doris
that referenced
this pull request
Jul 10, 2022
compiletheworld
force-pushed
the
unique-key-merge-on-write-delete-bitmap
branch
from
dd70619 to
f1d92cc
Compare
compiletheworld
added a commit
to compiletheworld/doris
that referenced
this pull request
Jul 11, 2022
github-actions
bot
removed
the
approved
compiletheworld
force-pushed
the
unique-key-merge-on-write-delete-bitmap
branch
from
f1d92cc to
59be26d
Compare
morningman
approved these changes
Jul 12, 2022
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
compiletheworld
added a commit
to compiletheworld/doris
that referenced
this pull request
Jul 14, 2022
… by DSIP-018 (apache#10548) Missing delete bitmap for copy constructor of `TabletMeta(TabletMeta&)`.
compiletheworld
added a commit
to compiletheworld/doris
that referenced
this pull request
Jul 14, 2022
… by DSIP-018 (apache#10548) Missing delete bitmap for copy constructor of `TabletMeta(TabletMeta&)`.
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 1, 2022
…18 (apache#10548) Add delete bitmap for DSIP-018: Support Merge-On-Write implementation for UNIQUE KEY data model
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 1, 2022
… by DSIP-018 (apache#10548) (apache#10863) Missing delete bitmap for copy constructor of `TabletMeta(TabletMeta&)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add delete bitmap for
DSIP-018: Support Merge-On-Write implementation for UNIQUE KEY data model
Problem Summary:
Checklist(Required)
Further comments