Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jul 4, 2022

Proposed changes

Issue Number: close #xxx

Problem Summary:

  1. Support "show proc 'catalogs/'"

  2. Refactor some interface implementation of HMSExternalDataSource, HMSExternalDatabase, HMSExternalTable.

    1. The meta instance id(dsId, dbId, tblId) is now generated from Catalog.getNextId()
    2. Each meta instance(ds, db, tbl) will only be created once, so that the id of these instances will not be changed in each call.
  3. Remove duplicate interface implementation of DataSourceIf, DatabaseIf.

Checklist(Required)

  1. Does it affect the original behavior: (No)
  2. Has unit tests been added: (No Need)
  3. Has document been added or modified: (No Need)
  4. Does it need to update dependencies: (No)
  5. Are there any changes that cannot be rolled back: (No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Jul 4, 2022
table.readLock();
try {
if (!isAllTables) {
if (table.getType() == TableType.HMS_EXTERNAL_TABLE) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewer: unify the logic, no need to use a special if branch to handle HMS_EXTERNAL_TABLE

Copy link
Contributor

@Jibing-Li Jibing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit f40ae7c into apache:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/multi-catalog area/planner Issues or PRs related to the query planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants