[bugfix 1.1.1] fix bug of vhash join build#10614
Merged
yiguolei merged 2 commits intoapache:masterfrom Jul 5, 2022
Merged
Conversation
| #include "vec/exprs/vexpr_context.h" | ||
| #include "vec/utils/template_helpers.hpp" | ||
| #include "vec/utils/util.hpp" | ||
| #include "gutil/strings/substitute.h" |
Contributor
There was a problem hiding this comment.
should use BE code formater to format the code.
dataroaring
reviewed
Jul 5, 2022
Contributor
dataroaring
left a comment
There was a problem hiding this comment.
It is better to explain how the bug happens.
Contributor
Author
|
Comment is added in Problem Summary. |
jacktengg
added a commit
to jacktengg/incubator-doris
that referenced
this pull request
Jul 18, 2022
Merge fix of apache#10614 to branch dev-1.1.1.
yiguolei
pushed a commit
that referenced
this pull request
Jul 18, 2022
Merge fix of #10614 to branch dev-1.1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #10595
Problem Summary:
When build hash table in
HashJoinNode::_hash_table_build, build side data is collected as a vector of Blocks of size 4G at maximum, if it happens that the total size of build side data is exactly e.g. 4G, then an empty Block will be added to the vector:Later when building RF in
RuntimeFilterSlotsBase::insert, it will try to get a column from an empty Block, which causes the problem.Also fixed a potential bug: when build side data exceed 4G * 128, the Blocks added previously into the vector may be relocated, which will invalidate the Block address used as map key in
td::unordered_map<const Block*, std::vector<int>> _inserted_rows;.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...