[Enhancement] Add column prune support for VOlapScanNode#10615
Merged
yiguolei merged 13 commits intoapache:masterfrom Jul 8, 2022
Merged
[Enhancement] Add column prune support for VOlapScanNode#10615yiguolei merged 13 commits intoapache:masterfrom
yiguolei merged 13 commits intoapache:masterfrom
Conversation
github-actions
bot
added
area/planner
3 tasks
yiguolei
reviewed
Jul 8, 2022
| for (const auto& slot_desc : _tuple_desc->slots()) { | ||
| _output_slot_flags.emplace_back(_output_slot_ids.empty() || | ||
| std::find(_output_slot_ids.begin(), _output_slot_ids.end(), | ||
| slot_desc->id()) != _output_slot_ids.end()); |
Contributor
Author
There was a problem hiding this comment.
Only when the slot_desc 's against output_slot_ids exists, the flag could be true
yiguolei
reviewed
Jul 8, 2022
be/src/vec/exec/volap_scan_node.cpp
Outdated
| auto slots = _tuple_desc->slots(); | ||
| for (int i = 0; i < slots.size(); i++) { | ||
| if (!_output_slot_flags[i]) { | ||
| (*std::move(columns[i])).assume_mutable()->clear(); |
yiguolei
reviewed
Jul 8, 2022
be/src/vec/exec/volap_scanner.h
Outdated
| @@ -112,6 +112,7 @@ class VOlapScanner { | |||
| std::vector<bool> _runtime_filter_marks; | |||
|
|
|||
| int _id; | |||
Contributor
Author
There was a problem hiding this comment.
I think it would be helpful when debugging, cause the id of volapscanner always be -1 now, maybe it should be marked as compile in debug only...
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Jul 10, 2022
…che#10615)" This reverts commit e37d294.
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Jul 10, 2022
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Jul 11, 2022
yiguolei
pushed a commit
that referenced
this pull request
Jul 11, 2022
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 1, 2022
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
As we don't prune column on the olap scan, doris always serialize a lot of uneccesary column in multi BE scenes which cause a huge impact on the performance.
Problem Summary:
Env: 1FE 3BE
Data Size: 1G tpch tools generated data
We use tpch q13 as example:
time cost before :
0.99
0.95
0.98
1.11
1.04
after this commit:
0.74
0.67
0.71
0.74
0.68
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...