Skip to content

[improve](planner): split output expr to multiple line.#10710

Merged
yiguolei merged 2 commits intoapache:masterfrom
jackwener:identation
Jul 10, 2022
Merged

[improve](planner): split output expr to multiple line.#10710
yiguolei merged 2 commits intoapache:masterfrom
jackwener:identation

Conversation

@jackwener
Copy link
Member

Proposed changes

Issue Number: close #xxx

Problem Summary:

Describe the overview of changes.

split output expr to multiple line.

+---------------------------------------------------+
| Explain String                                    |
+---------------------------------------------------+
| PLAN FRAGMENT 0                                   |
|   OUTPUT EXPRS:                                   |
|     <slot 9> `user_id`                            |
|     <slot 11> `default_cluster:test`.`tbl`.`date` |
|     <slot 10> `city`                              |
|     <slot 12> `default_cluster:test`.`tbl`.`age`  |
+---------------------------------------------------+

Checklist(Required)

  1. Does it affect the original behavior: Yes
  2. Has unit tests been added: No need
  3. Has document been added or modified: No need
  4. Does it need to update dependencies: No
  5. Are there any changes that cannot be rolled back: No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

+---------------------------------------------------+
| Explain String                                    |
+---------------------------------------------------+
| PLAN FRAGMENT 0                                   |
|   OUTPUT EXPRS:                                   |
|     <slot 9> `user_id`                            |
|     <slot 11> `default_cluster:test`.`tbl`.`date` |
|     <slot 10> `city`                              |
|     <slot 12> `default_cluster:test`.`tbl`.`age`  |
+---------------------------------------------------+
@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Jul 8, 2022
yiguolei
yiguolei previously approved these changes Jul 8, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

PR approved by anyone and no changes requested.

@jackwener jackwener added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jul 9, 2022
@github-actions github-actions bot added kind/test and removed approved Indicates a PR has been approved by one committer. labels Jul 9, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit a6e4c88 into apache:master Jul 10, 2022
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Aug 1, 2022
* [improve](planner): split output expr to multiple line.

+---------------------------------------------------+
| Explain String                                    |
+---------------------------------------------------+
| PLAN FRAGMENT 0                                   |
|   OUTPUT EXPRS:                                   |
|     <slot 9> `user_id`                            |
|     <slot 11> `default_cluster:test`.`tbl`.`date` |
|     <slot 10> `city`                              |
|     <slot 12> `default_cluster:test`.`tbl`.`age`  |
+---------------------------------------------------+

* *: fix UT and regression-test.
@jackwener jackwener deleted the identation branch September 8, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants