[enhancement](singal) output git commit id when the program coredump #10788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiguolei
reviewed
Jul 12, 2022
be/src/common/signal_handler.h
Outdated
| formatter.AppendString(" try \"date -d @"); | ||
| formatter.AppendUint64(static_cast<uint64>(time_in_sec), 10); | ||
| formatter.AppendString("\" if you are using GNU date ***\n"); | ||
| formatter.AppendString("*** Current BE version: "); |
Contributor
There was a problem hiding this comment.
Do not use this method. These code will allocate memory and string is very complicated. std::string get_build_version(bool compact) {
std::stringstream ss;
ss << DORIS_BUILD_VERSION
#ifdef NDEBUG
<< " RELEASE"
#else
<< " DEBUG"
#endif
<< " (build " << DORIS_BUILD_HASH << ")";
if (!compact) {
ss << std::endl << "Built on " << DORIS_BUILD_TIME << " by " << DORIS_BUILD_INFO;
}
return ss.str();
}
You could just use the macro
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 1, 2022
…pache#10788) * [enhancement](singal) output git commit id when the program coredump * modift output info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
output git commit id when the program coredump。
like this:
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...