Skip to content

[Bug](array-type) Fix the core dump caused by unaligned __int128#11020

Merged
BiteTheDDDDt merged 2 commits intoapache:masterfrom
adonis0147:int128
Jul 20, 2022
Merged

[Bug](array-type) Fix the core dump caused by unaligned __int128#11020
BiteTheDDDDt merged 2 commits intoapache:masterfrom
adonis0147:int128

Conversation

@adonis0147
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem Summary:

Similar to #10775 .
This issue may occur when using stream load by json file.

Checklist(Required)

  1. Does it affect the original behavior: No
  2. Has unit tests been added: Yes
  3. Has document been added or modified: No Need
  4. Does it need to update dependencies: No
  5. Are there any changes that cannot be rolled back: No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@adonis0147 adonis0147 changed the title [feature-wip](array-type) Fix the core dump caused by unaligned __int128 [Bug](array-type) Fix the core dump caused by unaligned __int128 Jul 19, 2022
BiteTheDDDDt
BiteTheDDDDt previously approved these changes Jul 20, 2022
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 20, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 20, 2022
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt BiteTheDDDDt merged commit e5663f9 into apache:master Jul 20, 2022
@adonis0147 adonis0147 deleted the int128 branch July 20, 2022 08:39
miswujian pushed a commit to miswujian/doris that referenced this pull request Jul 28, 2022
…che#11020)

Fix the core dump caused by unaligned __int128 and change DEFAULT_ALIGNMENT
whutpencil pushed a commit to whutpencil/incubator-doris that referenced this pull request Jul 29, 2022
…che#11020)

Fix the core dump caused by unaligned __int128 and change DEFAULT_ALIGNMENT
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Aug 1, 2022
…che#11020)

Fix the core dump caused by unaligned __int128 and change DEFAULT_ALIGNMENT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants