[improvement] Simplify scan node logic: removing _materialized_blocks…#11060
Closed
jacktengg wants to merge 3 commits intoapache:masterfrom
Closed
[improvement] Simplify scan node logic: removing _materialized_blocks…#11060jacktengg wants to merge 3 commits intoapache:masterfrom
jacktengg wants to merge 3 commits intoapache:masterfrom
Conversation
jacktengg
force-pushed
the
refactor-scan-node-queue
branch
2 times, most recently
from
e3fac25 to
eb39071
Compare
jacktengg
force-pushed
the
refactor-scan-node-queue
branch
from
eb39071 to
3e27ef6
Compare
morningman
reviewed
Aug 2, 2022
be/src/vec/exec/volap_scan_node.cpp
Outdated
| eos = true; | ||
| status = Status::Cancelled("Cancelled"); | ||
| LOG(INFO) << "Scan thread cancelled, cause query done, maybe reach limit."; | ||
| LOG(INFO) << "Scan thread cancelled."; |
Contributor
There was a problem hiding this comment.
I think this log can be removed.
Contributor
|
Could you please explain more about the threading model of this olap scan node.
So that other developer can easily understand its logic |
jacktengg
force-pushed
the
refactor-scan-node-queue
branch
2 times, most recently
from
1c5e09f to
d1b4201
Compare
jacktengg
force-pushed
the
refactor-scan-node-queue
branch
from
d1b4201 to
3ab680c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… and transfer thread
Proposed changes
Issue Number: close #xxx
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...