Skip to content

[enhancement](workflow) Add a workflow for Clang check#11083

Merged
yiguolei merged 3 commits intoapache:masterfrom
adonis0147:workflow
Jul 22, 2022
Merged

[enhancement](workflow) Add a workflow for Clang check#11083
yiguolei merged 3 commits intoapache:masterfrom
adonis0147:workflow

Conversation

@adonis0147
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem Summary:

Currently, we should support building from source by Clang, but we lack related checks. It is inconvenient to inspect and fix compilation errors reported by Clang manually.

This pr adds a workflow for Clang check.

REMARK

For the sake of speed, the workflow copy the prebuilt third-party packages from docker image directly rather than build them from source. We must update the image if we modify the third-party packages.

Checklist(Required)

  1. Does it affect the original behavior: No
  2. Has unit tests been added: No Need
  3. Has document been added or modified: No Need
  4. Does it need to update dependencies: No
  5. Are there any changes that cannot be rolled back: No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 21, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 9017afb into apache:master Jul 22, 2022
@adonis0147 adonis0147 deleted the workflow branch July 22, 2022 02:22
miswujian pushed a commit to miswujian/doris that referenced this pull request Jul 28, 2022
whutpencil pushed a commit to whutpencil/incubator-doris that referenced this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants