Skip to content

[enhance](*): improve code about optional#11153

Merged
924060929 merged 1 commit intoapache:masterfrom
jackwener:optional
Jul 26, 2022
Merged

[enhance](*): improve code about optional#11153
924060929 merged 1 commit intoapache:masterfrom
jackwener:optional

Conversation

@jackwener
Copy link
Member

Proposed changes

Issue Number: close #xxx

Problem Summary:

improve code about optional

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/nereids area/planner Issues or PRs related to the query planner area/routine load labels Jul 24, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@924060929 924060929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 26, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@924060929 924060929 merged commit a3df2e5 into apache:master Jul 26, 2022
adonis0147 pushed a commit to adonis0147/doris that referenced this pull request Jul 26, 2022
miswujian pushed a commit to miswujian/doris that referenced this pull request Jul 28, 2022
whutpencil pushed a commit to whutpencil/incubator-doris that referenced this pull request Jul 29, 2022
@jackwener jackwener deleted the optional branch September 8, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load area/nereids area/planner Issues or PRs related to the query planner area/routine load reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants