[feature-wip](multi-catalog) support pruning buckets for hive bucket table#11156
Merged
morningman merged 1 commit intoapache:masterfrom Jul 27, 2022
Merged
[feature-wip](multi-catalog) support pruning buckets for hive bucket table#11156morningman merged 1 commit intoapache:masterfrom
morningman merged 1 commit intoapache:masterfrom
Conversation
github-actions
bot
added
the
area/planner
morningman
reviewed
Jul 25, 2022
| } | ||
| } else { | ||
| valid = false; | ||
| LOG.warn("File {} is not a bucket file in hive table {}, skip bucket pruning.", fileName, tableName); |
| } | ||
| } | ||
| if (valid) { | ||
| LOG.info("{} / {} input splits in hive table {} after bucket pruning.", |
| return getSplitsByPath(inputFormat, configuration, splitsPath); | ||
| result = getSplitsByPath(inputFormat, configuration, splitsPath); | ||
| } | ||
| Optional<Set<Integer>> prunedBuckets = HiveBucketUtil.getPrunedBuckets( |
Contributor
There was a problem hiding this comment.
Looks like we can merge getPrunedBuckets and getPrunedSplitsByBuckets into one method.
To make it simpler to use?
AshinGau
force-pushed
the
bucket-prune
branch
5 times, most recently
from
74fba98 to
9179e12
Compare
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
miswujian
pushed a commit
to miswujian/doris
that referenced
this pull request
Jul 28, 2022
…table (apache#11156) 1. Spark currently does not populate bucketed output which is compatible with Hive, so spark bucket table is not supported in current implementation. 2. Hive 3.0 introduced bucket version 2, but doris still uses hive 2.3.7 which lacks the hash function of version 2, so I refer to the implementation of Trino and copy the hash function from hive. 3. Current implementation doest not support the table with multiple bucketed columns, and only support `Equal` and `In` predicates.
whutpencil
pushed a commit
to whutpencil/incubator-doris
that referenced
this pull request
Jul 29, 2022
…table (apache#11156) 1. Spark currently does not populate bucketed output which is compatible with Hive, so spark bucket table is not supported in current implementation. 2. Hive 3.0 introduced bucket version 2, but doris still uses hive 2.3.7 which lacks the hash function of version 2, so I refer to the implementation of Trino and copy the hash function from hive. 3. Current implementation doest not support the table with multiple bucketed columns, and only support `Equal` and `In` predicates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support pruning buckets for hive bucket table.
Notes
EqualandInpredicates.Profit
Suppose
lineitemtable in tpch(sf=100) is bucketed by l_orderkey into 96 buekts, when query:Splits scanning reduced from 144 to 6.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...