Skip to content

[fix](auth) Forbid grant USAGE_PRIV to database.table#11234

Merged
yiguolei merged 3 commits intoapache:masterfrom
morningman:drop_user_bug
Jul 27, 2022
Merged

[fix](auth) Forbid grant USAGE_PRIV to database.table#11234
yiguolei merged 3 commits intoapache:masterfrom
morningman:drop_user_bug

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jul 27, 2022

Proposed changes

Issue Number: close #11235

Problem Summary:

The USAGE_PRIV can not be granted to database.table level.
And it may cause editlog replay bug.

Checklist(Required)

  1. Type of your changes:
    • Improvement
    • Fix
    • Feature-WIP
    • Feature
    • Doc
    • Refator
    • Others:
  2. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  3. Has unit tests been added:
    • Yes
    • No
    • No Need
  4. Has document been added or modified:
    • Yes
    • No
    • No Need
  5. Does it need to update dependencies:
    • Yes
    • No
  6. Are there any changes that cannot be rolled back:
    • Yes
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. dev/1.1.2 labels Jul 27, 2022
@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Jul 27, 2022
yiguolei
yiguolei previously approved these changes Jul 27, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 27, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 27, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit be2ac6a into apache:master Jul 27, 2022
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Jul 27, 2022
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Jul 27, 2022
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Jul 27, 2022
yiguolei added a commit that referenced this pull request Jul 27, 2022
Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
miswujian pushed a commit to miswujian/doris that referenced this pull request Jul 28, 2022
whutpencil pushed a commit to whutpencil/incubator-doris that referenced this pull request Jul 29, 2022
Henry2SS pushed a commit to Henry2SS/incubator-doris that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner dev/merge-1.1.2 kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] FE start failed at replaying drop user edit log

2 participants