[improvement]Use phmap::flat_hash_set in AggregateFunctionUniq#11257
Merged
yiguolei merged 1 commit intoapache:masterfrom Jul 29, 2022
Merged
[improvement]Use phmap::flat_hash_set in AggregateFunctionUniq#11257yiguolei merged 1 commit intoapache:masterfrom
yiguolei merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
PR approved by anyone and no changes requested. |
mrhhsg
force-pushed
the
distinct_phmap
branch
2 times, most recently
from
7d77293 to
56d437f
Compare
wangbo
reviewed
Jul 29, 2022
| set.rehash(set.size() + rhs_set.size()); | ||
|
|
||
| for (auto elem : rhs_set) { | ||
| set.insert(elem); |
Contributor
There was a problem hiding this comment.
phmap has merge method, is that same with insert one by one?
Member
Author
There was a problem hiding this comment.
Yes, phmap::merge inserts elements one by one and it requires the src(rhs) is not constant.
wangbo
reviewed
Jul 29, 2022
| auto& set = this->data(place).set; | ||
| write_var_uint(set.size(), buf); | ||
| for (const auto& elem : set) { | ||
| write_pod_binary(elem, buf); |
Contributor
There was a problem hiding this comment.
How about add a Todo here; After phmap is included in BE's code. We can serialize phmap in copy way
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
Test on clikcbench with SQL:
Execution time reduced to 7.60 sec from 9.73 sec.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...