Skip to content

[fix](planner)do not change non-null to nullable for outer join table slot#11268

Merged
dataroaring merged 4 commits intoapache:masterfrom
morrySnow:fix_outer_join
Jul 29, 2022
Merged

[fix](planner)do not change non-null to nullable for outer join table slot#11268
dataroaring merged 4 commits intoapache:masterfrom
morrySnow:fix_outer_join

Conversation

@morrySnow
Copy link
Contributor

Proposed changes

Issue Number: close #11250

Problem Summary:

currently we set nullable to all slot of outer join table. but we should follow nullable attribute of column in table under vectorized engine.

Checklist(Required)

  1. Type of your changes:
    • Improvement
    • Fix
    • Feature-WIP
    • Feature
    • Doc
    • Refator
    • Others:
  2. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  3. Has unit tests been added:
    • Yes
    • No
    • No Need
  4. Has document been added or modified:
    • Yes
    • No
    • No Need
  5. Does it need to update dependencies:
    • Yes
    • No
  6. Are there any changes that cannot be rolled back:
    • Yes
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Jul 27, 2022
kpfly
kpfly previously approved these changes Jul 28, 2022
Copy link

@kpfly kpfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring previously approved these changes Jul 28, 2022
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 28, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 28, 2022
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 5999666 into apache:master Jul 29, 2022
@morrySnow morrySnow deleted the fix_outer_join branch September 7, 2022 01:53
wangbo pushed a commit to wangbo/incubator-doris that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] be core,doris::vectorized::VMergeIteratorContext::copy_row

3 participants