[refactor](array-type) optimize the array_distinct and array_sort fun… #11306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xy720
reviewed
Jul 29, 2022
Member
xy720
left a comment
xy720
left a comment
There was a problem hiding this comment.
There are still much duplicate code between function_array_sort.cpp and function_array_distinct.cpp. Is there any good idea to extract these code out?
| } | ||
|
|
||
| auto res_val = | ||
| Impl::_execute_by_type(*src_nested_column, src_offsets, *dest_nested_column, |
Member
There was a problem hiding this comment.
Suggested change
| Impl::_execute_by_type(*src_nested_column, src_offsets, *dest_nested_column, | |
| Impl::execute(*src_nested_column, src_offsets, *dest_nested_column, |
I think execute is better. Because we may be add a function in future which don't need to classify the execute by type.
| static bool _execute_string(const IColumn& src_column, const ColumnArray::Offsets& src_offsets, | ||
| IColumn& dest_column, ColumnArray::Offsets& dest_offsets, | ||
| const NullMapType* src_null_map, NullMapType* dest_null_map) { | ||
| const ColumnString* src_data_concrete = reinterpret_cast<const ColumnString*>(&src_column); |
Member
There was a problem hiding this comment.
Duplicate with function_array_distinct.cpp
If it is hard to add an abstract method, you can put the duplicate code into function_array_utils.h and use a common util method instead.
| return false; | ||
| } | ||
|
|
||
| ColumnString& dest_column_string = reinterpret_cast<ColumnString&>(dest_column); |
xy720
added
kind/refactor
Contributor
Author
ok，I will re-check again. |
carlvinhust2012
force-pushed
the
array-load
branch
from
36f8583 to
6a22613
Compare
carlvinhust2012
force-pushed
the
array-load
branch
from
6a22613 to
2e53fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #10052
Problem Summary:
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...