Skip to content

[chore](fe)reject illegal import#11311

Merged
yiguolei merged 1 commit intoapache:masterfrom
morrySnow:reject_junit4_for_nereids
Jul 29, 2022
Merged

[chore](fe)reject illegal import#11311
yiguolei merged 1 commit intoapache:masterfrom
morrySnow:reject_junit4_for_nereids

Conversation

@morrySnow
Copy link
Copy Markdown
Contributor

@morrySnow morrySnow commented Jul 28, 2022

Problem Summary:

Reject below:

  • com.clearspring.analytics.util.*: in anywhere
  • junit4: package under nereids

Checklist(Required)

  1. Type of your changes:
    • Improvement
    • Fix
    • Feature-WIP
    • Feature
    • Doc
    • Refator
    • Others:
  2. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  3. Has unit tests been added:
    • Yes
    • No
    • No Need
  4. Has document been added or modified:
    • Yes
    • No
    • No Need
  5. Does it need to update dependencies:
    • Yes
    • No
  6. Are there any changes that cannot be rolled back:
    • Yes
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

jackwener
jackwener approved these changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 29, 2022

PR approved by anyone and no changes requested.

yiguolei
yiguolei approved these changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 6424992 into apache:master Jul 29, 2022
whutpencil pushed a commit to whutpencil/incubator-doris that referenced this pull request Jul 29, 2022
@morrySnow @whutpencil
[fe-package]reject illegal import (apache#11311)
31ed6bd
@morrySnow morrySnow deleted the reject_junit4_for_nereids branch September 7, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@jackwener jackwener jackwener approved these changes

Assignees

No one assigned

Labels

area/nereids reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morrySnow @yiguolei @jackwener