Skip to content

[Fix](array)Add regresstion-test for array_slice function#11329

Merged
yiguolei merged 1 commit intoapache:masterfrom
xy720:add-mode-regression-test-for-array
Jul 30, 2022
Merged

[Fix](array)Add regresstion-test for array_slice function#11329
yiguolei merged 1 commit intoapache:masterfrom
xy720:add-mode-regression-test-for-array

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Jul 29, 2022

Proposed changes

Issue Number: close #xxx

in #11054 , we support array slice.
And then In #11200, we fix the bug to pass constant arguments to array functions.
Here we add the regression-test of array_slice function with constant arguments.

Problem Summary:

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xy720 xy720 added kind/test area/array-type Issues or PRs related to array type labels Jul 29, 2022
@xy720 xy720 changed the title Add regresstion-test for array_slice function [Fix]Add regresstion-test for array_slice function Jul 29, 2022
@xy720 xy720 changed the title [Fix]Add regresstion-test for array_slice function [Fix](array)Add regresstion-test for array_slice function Jul 29, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 9d9fcca into apache:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/array-type Issues or PRs related to array type kind/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants