Skip to content

[enhancement](Nereids) support all join type in Nereids that could do join by HashJoinNode#11446

Merged
924060929 merged 3 commits intoapache:masterfrom
morrySnow:outer_join
Aug 3, 2022
Merged

[enhancement](Nereids) support all join type in Nereids that could do join by HashJoinNode#11446
924060929 merged 3 commits intoapache:masterfrom
morrySnow:outer_join

Conversation

@morrySnow
Copy link
Contributor

Proposed changes

add and test join type:

  • inner join
  • left outer join
  • right outer join
  • left semi join
  • right semi join
  • left anti join
  • right anti join

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow morrySnow requested a review from 924060929 August 2, 2022 12:57
@morrySnow
Copy link
Contributor Author

@924060929 PTAL

Copy link
Contributor

@924060929 924060929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@924060929 924060929 merged commit a47eff1 into apache:master Aug 3, 2022
@morrySnow morrySnow deleted the outer_join branch September 7, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants