Skip to content

[fix](array-type) disable cast function to array type on origin exec engine.#11602

Merged
xy720 merged 4 commits intoapache:masterfrom
xy720:disable-cast-to-array-in-non-vec-engine
Aug 15, 2022
Merged

[fix](array-type) disable cast function to array type on origin exec engine.#11602
xy720 merged 4 commits intoapache:masterfrom
xy720:disable-cast-to-array-in-non-vec-engine

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Aug 8, 2022

Proposed changes

Issue Number: close #11592
is the sub issue of #7570

Problem summary

Currently, we already support cast to array on vectorized engine, and most of the array functions only supported on vectorized engine.
but on origin exec engine, we only support cast varchar to array.
Any other type cast to array on origin exec engine will cause be core dump.

This commit disable cast to array type on origin exec engine, except cast varchar to array type.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Aug 8, 2022
@xy720 xy720 added the area/array-type Issues or PRs related to array type label Aug 9, 2022
@cambyzju
Copy link
Contributor

LGTM

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xy720 xy720 merged commit 8f98357 into apache:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/array-type Issues or PRs related to array type area/planner Issues or PRs related to the query planner kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] cast to array function causes be core dump on non vec engine

3 participants