Skip to content

[minor](fe): remove redundant log and unused code. #11620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Aug 10, 2022
Merged

[minor](fe): remove redundant log and unused code. #11620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 0 additions & 113 deletions fe/fe-common/src/main/java/org/apache/doris/common/io/OutputBuffer.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/org/apache/doris/common/AliasGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public abstract class AliasGenerator {
public String getNextAlias() {
Preconditions.checkNotNull(aliasPrefix);
while (true) {
String candidateAlias = aliasPrefix + Integer.toString(numGeneratedAliases++);
String candidateAlias = aliasPrefix + (numGeneratedAliases++);
if (usedAliases.add(candidateAlias)) {
// add success
return candidateAlias;
Expand Down
8 changes: 0 additions & 8 deletions fe/fe-core/src/main/java/org/apache/doris/planner/AnalyticEvalNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
import org.apache.doris.thrift.TExplainLevel;
import org.apache.doris.thrift.TPlanNode;
import org.apache.doris.thrift.TPlanNodeType;
import org.apache.doris.thrift.TQueryOptions;

import com.google.common.base.Joiner;
import com.google.common.base.MoreObjects;
Expand Down Expand Up @@ -263,11 +262,4 @@ public String getNodeExplainString(String prefix, TExplainLevel detailLevel) {

return output.toString();
}

public void computeCosts(TQueryOptions queryOptions) {
Preconditions.checkNotNull(fragmentId,
"PlanNode must be placed into a fragment before calling this method.");
// TODO: come up with estimate based on window
cardinality = 0;
}
}
34 changes: 0 additions & 34 deletions fe/fe-core/src/main/java/org/apache/doris/transaction/AbortTransactionException.java
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions fe/spark-dpp/src/main/java/org/apache/doris/load/loadv2/etl/SparkEtlJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,12 @@ private void initSparkConfigs(Map<String, String> configs) {
}

private void initConfig() {
LOG.info("job config file path: " + jobConfigFilePath);
LOG.debug("job config file path: " + jobConfigFilePath);
Dataset<String> ds = spark.read().textFile(jobConfigFilePath);
String jsonConfig = ds.first();
LOG.info("rdd read json config: " + jsonConfig);
LOG.debug("rdd read json config: " + jsonConfig);
etlJobConfig = EtlJobConfig.configFromJson(jsonConfig);
LOG.info("etl job config: " + etlJobConfig);
LOG.debug("etl job config: " + etlJobConfig);
}

/*
Expand Down