Skip to content

[Enhancement](profile print format) print fragment and instance in a better format#11671

Merged
caiconghui merged 2 commits intoapache:masterfrom
Henry2SS:whz-fix-query-profile
Aug 11, 2022
Merged

[Enhancement](profile print format) print fragment and instance in a better format#11671
caiconghui merged 2 commits intoapache:masterfrom
Henry2SS:whz-fix-query-profile

Conversation

@Henry2SS
Copy link
Contributor

Proposed changes

Issue Number: close #11669

Problem summary

print fragment and instance in a better format

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

public static String printFragmentTree(ProfileTreeNode root) {
SimpleTreeNode rootNode = buildNode(root, PrintLevel.FRAGMENT);
StringBuilder sb = new StringBuilder();
// for better format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thx~

Copy link
Contributor

@caiconghui caiconghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 11, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@caiconghui caiconghui merged commit 7e828ad into apache:master Aug 11, 2022
Henry2SS added a commit to Henry2SS/incubator-doris that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/improvement reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] (print) fragment and instance should have a better format

2 participants