Skip to content

Comments

[Bugfix](Be)the return of get_const_col may be nullptr#11873

Closed
xiao-nanbei wants to merge 1 commit intoapache:masterfrom
xiao-nanbei:master
Closed

[Bugfix](Be)the return of get_const_col may be nullptr#11873
xiao-nanbei wants to merge 1 commit intoapache:masterfrom
xiao-nanbei:master

Conversation

@xiao-nanbei
Copy link

underlying problem: the return of get_const_col may be nullptr,but there is no judgment

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

underlying problem: the return of get_const_col may be nullptr,but there is no judgment
Copy link
Contributor

@stalary stalary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

@xiao-nanbei please rebase master to trigger the checks. And format the BE code

@github-actions
Copy link
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Feb 21, 2023
@github-actions github-actions bot closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants