Skip to content

[refactor](Nereids): merge rewrite job#11950

Merged
924060929 merged 1 commit intoapache:masterfrom
jackwener:job
Aug 23, 2022
Merged

[refactor](Nereids): merge rewrite job#11950
924060929 merged 1 commit intoapache:masterfrom
jackwener:job

Conversation

@jackwener
Copy link
Member

Proposed changes

Issue Number: close #xxx

Problem summary

merge rewrite job

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@jackwener jackwener force-pushed the job branch 3 times, most recently from cadd29d to 6634007 Compare August 22, 2022 14:43
Copy link
Contributor

@924060929 924060929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 23, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@924060929 924060929 merged commit 7602826 into apache:master Aug 23, 2022
@jackwener jackwener deleted the job branch September 8, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/nereids reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants