[feature-wip](parquet-reader) parquert scanner can read data#11970
Merged
dataroaring merged 1 commit intoapache:masterfrom Aug 26, 2022
wsjz:parquet_scanner_pass
Merged
[feature-wip](parquet-reader) parquert scanner can read data#11970dataroaring merged 1 commit intoapache:masterfrom wsjz:parquet_scanner_pass
dataroaring merged 1 commit intoapache:masterfrom
wsjz:parquet_scanner_pass
Conversation
cambyzju
reviewed
Aug 24, 2022
Contributor
|
please add some description about what this pr doing. |
Contributor
Author
use new parquet reader instead of old arrow reader WIP |
Gabriel39
reviewed
Aug 24, 2022
| : HdfsFileScanner(state, profile, params, ranges, pre_filter_texprs, counter) {} | ||
|
|
||
| ParquetFileHdfsScanner::~ParquetFileHdfsScanner() { | ||
| ParquetFileHdfsScanner::close(); |
Contributor
There was a problem hiding this comment.
I think we should move this call to FileScanNode when this FileScanner is ready to close.
Contributor
Author
There was a problem hiding this comment.
I think FileScanNode in this version we can keep the same with before
Contributor
|
Hi @wsjz I have fixed a failure regression case and you need rebase master and push again to resolve this. |
Contributor
Author
OK |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Aug 31, 2022
…11970) Co-authored-by: jinzhe <jinzhe@selectdb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
finished first version of the new parquet scanner and reader, this version just support primary type
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...