[dev-1.1.2](memtracker) Fix old mem tracker consumption is less than 0#12000
Merged
yiguolei merged 1 commit intoapache:dev-1.1.2from Aug 23, 2022
Merged
Conversation
xinyiZzz
added a commit
that referenced
this pull request
Aug 23, 2022
Henry2SS
pushed a commit
to Henry2SS/incubator-doris
that referenced
this pull request
Sep 14, 2022
Henry2SS
pushed a commit
to Henry2SS/incubator-doris
that referenced
this pull request
Sep 14, 2022
…n 0 in old mem tracker apache#11980" (apache#12001) This reverts commit c33ebbf. true error fixed in apache#12000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
The old and new mem trackers coexist on v1.1.2. In #11943,
_instance_mem_trackerand_new_instance_mem_trackerare bound to the same profile by mistake, and the memory size recorded by_new_instance_mem_trackerthrough the tcmalloc hook is not always positive.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...