Skip to content

[fix](memtracker) Improve performance of tracking real physical memory of PodArray#12021

Merged
yiguolei merged 1 commit intoapache:masterfrom
xinyiZzz:mem_tracker_factor_v2_fix14
Aug 24, 2022
Merged

[fix](memtracker) Improve performance of tracking real physical memory of PodArray#12021
yiguolei merged 1 commit intoapache:masterfrom
xinyiZzz:mem_tracker_factor_v2_fix14

Conversation

@xinyiZzz
Copy link
Copy Markdown
Contributor

@xinyiZzz xinyiZzz commented Aug 24, 2022

Proposed changes

Issue Number: close #12019

Problem summary

  1. Transfer to between mem tracke limiters, no longer consume process mem tracker.
  2. Change consume_local to cache_consume_local.
  3. The threshold of PodArray reset_peak is changed to 4096.
  4. process_mem_tracker is no longer used to limit memory, mem limit is changed to -1,

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 1304a17 into apache:master Aug 24, 2022
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Aug 24, 2022
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Aug 24, 2022
yiguolei pushed a commit that referenced this pull request Aug 25, 2022
Henry2SS pushed a commit to Henry2SS/incubator-doris that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Tracking real physical memory usage of PodArray affects performance

2 participants