Skip to content

[fix](array-type) add ARRAY_BOOLEAN support for lots of array functions#12079

Merged
yiguolei merged 1 commit intoapache:masterfrom
cambyzju:array-function-0825
Aug 26, 2022
Merged

[fix](array-type) add ARRAY_BOOLEAN support for lots of array functions#12079
yiguolei merged 1 commit intoapache:masterfrom
cambyzju:array-function-0825

Conversation

@cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Aug 25, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

Lots of array functions already support subtype BOOLEAN, but not registered.
image

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@cambyzju cambyzju added the area/array-type Issues or PRs related to array type label Aug 25, 2022
@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions kind/test labels Aug 25, 2022
@cambyzju cambyzju force-pushed the array-function-0825 branch from a6a4b00 to 5413f57 Compare August 26, 2022 02:18
xy720
xy720 previously approved these changes Aug 26, 2022
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 26, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@cambyzju cambyzju force-pushed the array-function-0825 branch from 5413f57 to 38ebc5e Compare August 26, 2022 05:48
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 26, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 2b3a5b5 into apache:master Aug 26, 2022
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/array-type Issues or PRs related to array type area/sql/function Issues or PRs related to the SQL functions kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants