Skip to content

[Enhancement](compaction) empty string optimize for binary dict code#12259

Merged
BiteTheDDDDt merged 1 commit intoapache:masterfrom
BiteTheDDDDt:dev_0901
Sep 2, 2022
Merged

[Enhancement](compaction) empty string optimize for binary dict code#12259
BiteTheDDDDt merged 1 commit intoapache:masterfrom
BiteTheDDDDt:dev_0901

Conversation

@BiteTheDDDDt
Copy link
Contributor

Proposed changes

before:
- 5.85% doris::segment_v2::BinaryDictPageBuilder::add                                                                                                                            ▒
    + 2.26% phmap::priv::raw_hash_set<phmap::priv::FlatHashMapPolicy<doris::Slice, unsigned int>, doris::segment_v2::BinaryDictPageBuilder::HashOfSlice, phmap::EqualTo<doris::Sli▒
    + 0.70% doris::segment_v2::BinaryPlainPageBuilder<(doris::FieldType)17>::add                                                                                                  ▒
+ 1.41% doris::segment_v2::TypedZoneMapIndexWriter<(doris::PrimitiveType)23>::add_values



after:
- 4.91% doris::segment_v2::BinaryDictPageBuilder::add                                                                                                                            ▒
    + 1.06% doris::segment_v2::BinaryPlainPageBuilder<(doris::FieldType)17>::add                                                                                                  ▒
        1.00% phmap::priv::raw_hash_set<phmap::priv::FlatHashMapPolicy<doris::Slice, unsigned int>, doris::segment_v2::BinaryDictPageBuilder::HashOfSlice, phmap::EqualTo<doris::Sli▒
        0.73% doris::segment_v2::BinaryDictPageBuilder::is_page_full                                                                                                                ▒
+ 0.60% doris::segment_v2::TypedZoneMapIndexWriter<(doris::PrimitiveType)23>::add_values

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@BiteTheDDDDt BiteTheDDDDt changed the title [enhancement](load/compaction) empty string optimize for binary dict code [Enhancement](compaction) empty string optimize for binary dict code Sep 1, 2022
Copy link
Member

@zenoyang zenoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit a8c8ebf into apache:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants