[feature-wip](unique-key-merge-on-write) update delete bitmap when increamental clone#12364
Merged
dataroaring merged 1 commit intoapache:masterfrom Sep 9, 2022
Merged
[feature-wip](unique-key-merge-on-write) update delete bitmap when increamental clone#12364dataroaring merged 1 commit intoapache:masterfrom
dataroaring merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Please add some description or link for this pr. |
zhannngchen
reviewed
Sep 6, 2022
| RETURN_IF_ERROR(calc_delete_bitmap(rowset->rowset_id(), segments, nullptr, delete_bitmap, | ||
| cur_version - 1, true)); | ||
|
|
||
| for (auto iter = delete_bitmap->delete_bitmap.begin(); |
Contributor
There was a problem hiding this comment.
Can we use the DeleteBitmap::merge method directly? As well as in another update_delete_bitmap method?
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Full clone will copy all delete bitmap from src tablet. Incremental clone can't copy the delete bitmap from src table because of compaction. So we should calculate the delete bitmap using incremental rowset data.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...