Skip to content

[enhancement](chore)add single empty line rule to fe check style for Nereids#12365

Merged
jackwener merged 1 commit intoapache:masterfrom
morrySnow:single_empty_line
Sep 6, 2022
Merged

[enhancement](chore)add single empty line rule to fe check style for Nereids#12365
jackwener merged 1 commit intoapache:masterfrom
morrySnow:single_empty_line

Conversation

@morrySnow
Copy link
Contributor

Proposed changes

reject multi empty line

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackwener jackwener merged commit f1507f9 into apache:master Sep 6, 2022
@morrySnow morrySnow deleted the single_empty_line branch September 6, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants