Skip to content

[Enhancement](column) remove ColumnString terminating zero and add a data_version for pblock#12456

Merged
BiteTheDDDDt merged 5 commits intoapache:masterfrom
BiteTheDDDDt:dev_0908
Sep 14, 2022
Merged

[Enhancement](column) remove ColumnString terminating zero and add a data_version for pblock#12456
BiteTheDDDDt merged 5 commits intoapache:masterfrom
BiteTheDDDDt:dev_0908

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Sep 8, 2022

Proposed changes

main change:

  1. remove ColumnString terminating zero
  2. add a data_version for pblock
  3. change EncryptionMode to enum class

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 14, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 0ead048 into apache:master Sep 14, 2022
@BiteTheDDDDt BiteTheDDDDt deleted the dev_0908 branch January 20, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants