Skip to content

[feature](nereids) implement uncheckedCast method in VarcharLiteral#12468

Merged
morrySnow merged 1 commit intoapache:masterfrom
Kikyou1997:fix/time_arith_expr
Sep 8, 2022
Merged

[feature](nereids) implement uncheckedCast method in VarcharLiteral#12468
morrySnow merged 1 commit intoapache:masterfrom
Kikyou1997:fix/time_arith_expr

Conversation

@Kikyou1997
Copy link
Copy Markdown
Contributor

@Kikyou1997 Kikyou1997 commented Sep 8, 2022

Proposed changes

Issue Number: noissue

Problem summary

Implement uncheckedCast on varchar Literal for a temp way to let TimestampArithmetic work.
We should remove these code and do implicit cast in TypeCoercion rule in future.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Kikyou1997
Copy link
Copy Markdown
Contributor Author

@morrySnow

morrySnow
morrySnow previously approved these changes Sep 8, 2022
@morrySnow
Copy link
Copy Markdown
Contributor

please add regression test

@Kikyou1997
Copy link
Copy Markdown
Contributor Author

please add regression test

added unit test

@morrySnow morrySnow changed the title [feature-wip](nereids) implement uncheckedCast method in VarcharLiteral [feature](nereids) implement uncheckedCast method in varchar literal Sep 8, 2022
@morrySnow morrySnow changed the title [feature](nereids) implement uncheckedCast method in varchar literal [feature](nereids) implement uncheckedCast method in VarcharLiteral Sep 8, 2022
@morrySnow morrySnow merged commit b4f0f39 into apache:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants