Skip to content

[enhance](information_schema) show hll type and bitmap type instead of unknown#12519

Merged
yiguolei merged 2 commits intoapache:masterfrom
ByteYue:enhance_schema_information
Sep 13, 2022
Merged

[enhance](information_schema) show hll type and bitmap type instead of unknown#12519
yiguolei merged 2 commits intoapache:masterfrom
ByteYue:enhance_schema_information

Conversation

@ByteYue
Copy link
Contributor

@ByteYue ByteYue commented Sep 9, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

Before this pr, when querying data type of hll/bitmap column, 'unknown' would be returned instead of the correct data type of queried column. Details are as followed:

jq4D8UjnCE

This pr aims to return the correct data type.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@ByteYue ByteYue force-pushed the enhance_schema_information branch from 1d23476 to f4dd5bc Compare September 9, 2022 15:37
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
but please add regression test for this case

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 58508ae into apache:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants