Skip to content

[enhancement](agg)remove unnessasery mem alloc and dealloc in agg node#12535

Merged
yiguolei merged 1 commit intoapache:masterfrom
starocean999:master_perf
Sep 15, 2022
Merged

[enhancement](agg)remove unnessasery mem alloc and dealloc in agg node#12535
yiguolei merged 1 commit intoapache:masterfrom
starocean999:master_perf

Conversation

@starocean999
Copy link
Copy Markdown
Contributor

@starocean999 starocean999 commented Sep 13, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

remove unnessasery mem alloc and dealloc in agg node

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Copy Markdown
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel39
Copy link
Copy Markdown
Contributor

Could you attach some performance tests?

@yiguolei yiguolei merged commit 8e4374b into apache:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants