Skip to content

Conversation

@BenjaminWenqiYu
Copy link
Contributor

@BenjaminWenqiYu BenjaminWenqiYu commented Sep 13, 2022

Proposed changes

should use CURRENT_DATE to obtain the correct result
Issue Number: close #12544

Problem summary

should use CURRENT_DATE to obtain the correct result.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

should use CURRENT_DATE to obtain the correct result
should use CURRENT_DATE to obtain the correct result
@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Sep 13, 2022
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BenjaminWenqiYu thanks for your contribution. Btw, CURDATE is an alias of CURRENTDATE and these two has the same implements. Could you give some details about the error you met? Maybe a screenshot contains a wrong result?

@BenjaminWenqiYu
Copy link
Contributor Author

@Gabriel39 Hi, when I use CURDATE, it got another result but not what I expected.
download

@BenjaminWenqiYu BenjaminWenqiYu changed the title Fix sql function doc [fix](doc)Fix sql function doc Sep 14, 2022
@Gabriel39
Copy link
Contributor

@Gabriel39 Hi, when I use CURDATE, it got another result but not what I expected. download

@BenjaminWenqiYu Actually this is a bug not a document mistake. And I fixed this bug by #12720 . You can double check this problem and I will close this PR if you have no other problems. Thanks!

@Gabriel39 Gabriel39 closed this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/docs Categorizes issue or PR as related to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix the date-time-functions doc.

2 participants