Skip to content

Conversation

@jackwener
Copy link
Member

Proposed changes

Issue Number: close #xxx

Problem summary

  • semi join transpose
  • enable ZIG_ZAG join reorder.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@jackwener jackwener force-pushed the semi branch 3 times, most recently from f812b7f to cb7920c Compare September 15, 2022 03:01
@jackwener jackwener changed the title [feature](Nereids): semi join transpose and enable ZIG_ZAG join reorder. [feature](Nereids): semi join transpose Sep 15, 2022
public class SemiJoinSemiJoinTranspose extends OneExplorationRuleFactory {
public static final SemiJoinSemiJoinTranspose INSTANCE = new SemiJoinSemiJoinTranspose();

public static Set<Pair<JoinType, JoinType>> typeSet = ImmutableSet.of(
Copy link
Contributor

@morrySnow morrySnow Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit typeSet -> VALID_TYPE_PAIR_SET. pls fix it in next PR

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 15, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@jackwener jackwener merged commit db8bc80 into apache:master Sep 15, 2022
@jackwener jackwener deleted the semi branch September 15, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/nereids reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants