Skip to content

[Bug](nereids) Fix UT when run test cases in package#12622

Merged
morrySnow merged 1 commit intoapache:masterfrom
adonis0147:fe-ut
Sep 15, 2022
Merged

[Bug](nereids) Fix UT when run test cases in package#12622
morrySnow merged 1 commit intoapache:masterfrom
adonis0147:fe-ut

Conversation

@adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented Sep 15, 2022

Proposed changes

NamedExpressionUtil::clear should reset the nextId rather than create a new IdGenerator<ExprId> because the old one may be referenced by other objects and it may cause some cases start in a dirty environment when we run test cases in package.

Issue Number: close #12631

Problem summary

If we run the nereids test cases in package in Intellij IDEA, we will see some cases fail.

See #12631 .

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@adonis0147 adonis0147 changed the title [Bug](nereids) Fix UT when test cases in package [Bug](nereids) Fix UT when run test cases in package Sep 15, 2022
@morrySnow morrySnow merged commit 0daa25d into apache:master Sep 15, 2022
@adonis0147 adonis0147 deleted the fe-ut branch September 16, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] (nereids) Fix UT when run test cases in package

2 participants