Skip to content

[feature-wip](unique-key-merge-on-write) fix calculate delete bitmap when flush memtable#12668

Merged
yiguolei merged 1 commit intoapache:masterfrom
liaoxin01:pk_cal_bm
Sep 17, 2022
Merged

[feature-wip](unique-key-merge-on-write) fix calculate delete bitmap when flush memtable#12668
yiguolei merged 1 commit intoapache:masterfrom
liaoxin01:pk_cal_bm

Conversation

@liaoxin01
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Multiple memtable should use the same version when calculate delete bitmap. Otherwise, updating the delete bitmap of the same segment with different versions will cause the delete bitmap on the segment to be overwritten.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit bac58a4 into apache:master Sep 17, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
@liaoxin01 liaoxin01 deleted the pk_cal_bm branch February 6, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants