[fix](load) fix stream load fail when setting strict mode#12684
Merged
yiguolei merged 4 commits intoapache:masterfrom Sep 17, 2022
Merged
[fix](load) fix stream load fail when setting strict mode#12684yiguolei merged 4 commits intoapache:masterfrom
yiguolei merged 4 commits intoapache:masterfrom
Conversation
| if (filter_map[i] && nullable_column->is_null_at(i)) { | ||
| if (_strict_mode && (_src_slot_descs_order_by_dest[dest_index]) && | ||
| !_src_block.get_by_position(dest_index).column->is_null_at(i)) { | ||
| !_src_block.get_by_position(_dest_slot_to_src_slot_index[dest_index]) |
Contributor
There was a problem hiding this comment.
Better use _dest_slot_to_src_slot_index.find to instead operator[], and add a check for not found situation
Contributor
Author
There was a problem hiding this comment.
If _src_slot_descs_order_by_dest[dest_index] is not nullptr, then the dest column has a src column, and dest_index exists in _dest_slot_to_src_slot_index.
be/src/exec/base_scanner.cpp
Outdated
| if (_src_slot_it == std::end(src_slot_desc_map)) { | ||
| return Status::InternalError("No src slot {} in src slot descs", it1->second); | ||
| } | ||
| auto src_slot_index = std::find(_src_slot_descs.cbegin(), _src_slot_descs.cend(), |
Contributor
There was a problem hiding this comment.
Maybe we can maintain a map represent <slot_id -> slot_index>, to prevent find desc in vector everytime.
luozenglin
force-pushed
the
fix_strict
branch
from
11b1c60 to
37f4b80
Compare
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #12683
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...