Skip to content

Conversation

@yiguolei
Copy link
Contributor

Proposed changes

This issue is introduced by #8096, the operator priority is wrong , so that in some cases, there will be many scanners.

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

yangzhg
yangzhg previously approved these changes Sep 22, 2022
Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added area/vectorization approved Indicates a PR has been approved by one committer. labels Sep 22, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei force-pushed the fix_scanner_compute_error branch from ed2d04f to 78b50b7 Compare September 23, 2022 02:04
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 23, 2022
@yiguolei yiguolei force-pushed the fix_scanner_compute_error branch from 78b50b7 to 00b1ace Compare September 23, 2022 06:37
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 7b230e4 into apache:master Sep 24, 2022
yiguolei added a commit that referenced this pull request Sep 26, 2022
Co-authored-by: yiguolei <yiguolei@gmail.com>
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
Co-authored-by: yiguolei <yiguolei@gmail.com>
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
Co-authored-by: yiguolei <yiguolei@gmail.com>
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
Co-authored-by: yiguolei <yiguolei@gmail.com>
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
Co-authored-by: yiguolei <yiguolei@gmail.com>
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
Co-authored-by: yiguolei <yiguolei@gmail.com>
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
Co-authored-by: yiguolei <yiguolei@gmail.com>
@yiguolei yiguolei deleted the fix_scanner_compute_error branch March 30, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants