[Improvement](predicate) Replace for-loop by memcpy#12867
Merged
HappenLee merged 1 commit intoapache:masterfrom Sep 25, 2022
Merged
[Improvement](predicate) Replace for-loop by memcpy#12867HappenLee merged 1 commit intoapache:masterfrom
HappenLee merged 1 commit intoapache:masterfrom
Conversation
github-actions
bot
added
area/vectorization
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Gabriel39
force-pushed
the
improve_predicate
branch
from
9196707 to
2005c61
Compare
github-actions
bot
removed
the
approved
Gabriel39
force-pushed
the
improve_predicate
branch
from
2005c61 to
440b015
Compare
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
FreeOnePlus
pushed a commit
to FreeOnePlus/doris
that referenced
this pull request
Oct 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR replace for-loop by memcpy.
I did two experiments.
Experiment 1
Run ckbench q20 and print a flame graph. Compare proportion of this function time to the total time.
I got:
for-loop:1.74%
memcpy:0.013%
Experiment 2
Run
SELECT JavaEnable FROM hits. 9900w+ rows returned and JavaEnable is SMALL INT.Compare the BlockLoadTime.
I got:
for-loop:1s225ms
memcpy:805.603ms
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...