Skip to content

[feature-wip](unique-key-merge-on-write) fix thread safe issue in BetaRowsetWriter#12875

Merged
dataroaring merged 6 commits intoapache:masterfrom
zhannngchen:primary-key-fix-segment-writer
Sep 27, 2022
Merged

[feature-wip](unique-key-merge-on-write) fix thread safe issue in BetaRowsetWriter#12875
dataroaring merged 6 commits intoapache:masterfrom
zhannngchen:primary-key-fix-segment-writer

Conversation

@zhannngchen
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zhannngchen zhannngchen force-pushed the primary-key-fix-segment-writer branch from 86787cf to 9155887 Compare September 23, 2022 01:54
liaoxin01
liaoxin01 previously approved these changes Sep 23, 2022
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zhannngchen zhannngchen force-pushed the primary-key-fix-segment-writer branch 6 times, most recently from dfbde41 to 9986c50 Compare September 26, 2022 08:24
@zhannngchen zhannngchen force-pushed the primary-key-fix-segment-writer branch from 9986c50 to 569fc3d Compare September 26, 2022 13:19
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 1cc15cc into apache:master Sep 27, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants