Skip to content

[Improvement](dict) optimize dictionary column (revert previous one) #12946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel39 merged 2 commits into from
Sep 24, 2022
Merged

[Improvement](dict) optimize dictionary column (revert previous one) #12946

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
823354b
Revert "[Improvement](dict) optimize dictionary column (#12880)"
Gabriel39 Sep 24, 2022
5e21758
[Improvement](dict) optimize dictionary column
Gabriel39 Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion be/src/vec/columns/column_dictionary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ class ColumnDictionary final : public COWHelper<IColumn, ColumnDictionary<T>> {

void clear() {
_dict_data->clear();
_code_convert_table.clear();
_hash_values.clear();
}

Expand All @@ -383,6 +384,7 @@ class ColumnDictionary final : public COWHelper<IColumn, ColumnDictionary<T>> {
void sort() {
size_t dict_size = _dict_data->size();

_code_convert_table.reserve(dict_size);
_perm.resize(dict_size);
for (size_t i = 0; i < dict_size; ++i) {
_perm[i] = i;
Expand Down Expand Up @@ -413,7 +415,7 @@ class ColumnDictionary final : public COWHelper<IColumn, ColumnDictionary<T>> {

bool empty() { return _dict_data->empty(); }

size_t avg_str_len() { return _total_str_len / _dict_data->size(); }
size_t avg_str_len() { return empty() ? 0 : _total_str_len / _dict_data->size(); }

private:
StringValue _null_value = StringValue();
Expand Down