Skip to content

[feature-wip](new-scan) support more load situation#12953

Merged
dataroaring merged 9 commits intoapache:masterfrom
morningman:support_missing_col
Sep 27, 2022
Merged

[feature-wip](new-scan) support more load situation#12953
dataroaring merged 9 commits intoapache:masterfrom
morningman:support_missing_col

Conversation

@morningman
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

  1. add orc reader in vfile_scanner
  2. refactor the logic of VFileScanner::_get_block_impl()
    1. Support load file with missing columns
    2. Support fill null or default value for missing columns

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/vectorization labels Sep 25, 2022
Copy link
Contributor

@Jibing-Li Jibing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit d80b7b9 into apache:master Sep 27, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/multi-catalog area/planner Issues or PRs related to the query planner area/vectorization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants