[fix](planner) : Incorrect result of CAST AS CHAR#12957
Closed
lsy3993 wants to merge 7 commits intoapache:masterfrom
lsy3993:lsy_cast_incorrect
Closed
[fix](planner) : Incorrect result of CAST AS CHAR#12957lsy3993 wants to merge 7 commits intoapache:masterfrom lsy3993:lsy_cast_incorrect
lsy3993 wants to merge 7 commits intoapache:masterfrom
lsy3993:lsy_cast_incorrect
Conversation
Contributor
|
We are not doing char type length processing in the execution engine, it seems that this will make us not have consistent performance globally |
Contributor
Author
|
This bug fix is only for the case of casting constant string in FE. When the cast statement calculates in BE, we may fix it later |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: #3861
Problem summary
when cast string to char(int), fe should judge the length of target char, rather than return whole string
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...