Skip to content

Comments

[chore](build) Fix compilation errors reported by clang-15#13000

Merged
adonis0147 merged 1 commit intoapache:masterfrom
adonis0147:clang-15
Sep 27, 2022
Merged

[chore](build) Fix compilation errors reported by clang-15#13000
adonis0147 merged 1 commit intoapache:masterfrom
adonis0147:clang-15

Conversation

@adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented Sep 27, 2022 •
edited
Loading

Proposed changes

Add a compile flag -Wno-unused-but-set-variable to build libGeo.a .

Problem summary

Fix the following error.

/Programs/doris/be/../gensrc/build//geo/wkt_yacc.y.cpp:1153:9: error: variable 'wkt_nerrs' set but not used [-Werror,-Wunused-but-set-variable]
    int yynerrs;
        ^
/Programs/doris/gensrc/build/geo/wkt_yacc.y.cpp:72:25: note: expanded from macro 'yynerrs'
#define yynerrs         wkt_nerrs
                        ^
1 error generated.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

BiteTheDDDDt
BiteTheDDDDt approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 27, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2022

PR approved by anyone and no changes requested.

@adonis0147 adonis0147 merged commit 7221068 into apache:master Sep 27, 2022
@adonis0147 adonis0147 deleted the clang-15 branch September 27, 2022 06:04
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
@adonis0147 @FreeOnePlus
[chore](build) Fix compilation errors reported by clang-15 (apache#13000
e593f47 
)

Add a compile flag -Wno-unused-but-set-variable to build libGeo.a .
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
@adonis0147 @FreeOnePlus
[chore](build) Fix compilation errors reported by clang-15 (apache#13000
f9d8c78 
)

Add a compile flag -Wno-unused-but-set-variable to build libGeo.a .
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
@adonis0147 @FreeOnePlus
[chore](build) Fix compilation errors reported by clang-15 (apache#13000
f8f4287 
)

Add a compile flag -Wno-unused-but-set-variable to build libGeo.a .
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
@adonis0147 @FreeOnePlus
[chore](build) Fix compilation errors reported by clang-15 (apache#13000
a7200a3 
)

Add a compile flag -Wno-unused-but-set-variable to build libGeo.a .
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
@adonis0147 @FreeOnePlus
[chore](build) Fix compilation errors reported by clang-15 (apache#13000
6a3b86f 
)

Add a compile flag -Wno-unused-but-set-variable to build libGeo.a .
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
@adonis0147 @FreeOnePlus
[chore](build) Fix compilation errors reported by clang-15 (apache#13000
f8c1a58 
)

Add a compile flag -Wno-unused-but-set-variable to build libGeo.a .
@adonis0147 adonis0147 mentioned this pull request Oct 27, 2022
Merged
13 tasks
adonis0147 added a commit that referenced this pull request Oct 27, 2022
@adonis0147
[chore](build) Pass the compile flag -Wno-unused-but-set-variable on …
bad9501 
…demand (#13716)

There are some issues with the compile flag `-Wno-unused-but-set-variable` for clang.
1. `-Wno-unused-but-set-variable` should be set when building source by clang-15 on Linux. (#13000 #13016)
2. On macOS Monterey, Apple Clang 13 may treat it as a unknown warning option and the compilation process may interrupt.

This PR introduces a better way to make this compile flag more portable.
1. Test whether the compiler recognizes this flag.
2. Add this flag if the compiler recognizes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adonis0147 @BiteTheDDDDt