Skip to content

[feature](Nereids) implicit cast StringLiteral to another side type of BinaryOperator if available#13038

Merged
morrySnow merged 1 commit intoapache:masterfrom
morrySnow:cast_string_literal
Sep 28, 2022
Merged

[feature](Nereids) implicit cast StringLiteral to another side type of BinaryOperator if available#13038
morrySnow merged 1 commit intoapache:masterfrom
morrySnow:cast_string_literal

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Sep 28, 2022

Proposed changes

for expression 5 > '1'. currently, we normalize it to '5' > '1'. After this PR, we normalize it to 5 > 1 to compatible with legacy planner.

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow morrySnow merged commit d532050 into apache:master Sep 28, 2022
@morrySnow morrySnow deleted the cast_string_literal branch September 28, 2022 13:34
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…f BinaryOperator if available (apache#13038)

for expression 5 > '1'. before this PR, we normalize it to '5' > '1'. After this PR, we normalize it to 5 > 1 to compatible with legacy planner.
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…f BinaryOperator if available (apache#13038)

for expression 5 > '1'. before this PR, we normalize it to '5' > '1'. After this PR, we normalize it to 5 > 1 to compatible with legacy planner.
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…f BinaryOperator if available (apache#13038)

for expression 5 > '1'. before this PR, we normalize it to '5' > '1'. After this PR, we normalize it to 5 > 1 to compatible with legacy planner.
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…f BinaryOperator if available (apache#13038)

for expression 5 > '1'. before this PR, we normalize it to '5' > '1'. After this PR, we normalize it to 5 > 1 to compatible with legacy planner.
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…f BinaryOperator if available (apache#13038)

for expression 5 > '1'. before this PR, we normalize it to '5' > '1'. After this PR, we normalize it to 5 > 1 to compatible with legacy planner.
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Oct 8, 2022
…f BinaryOperator if available (apache#13038)

for expression 5 > '1'. before this PR, we normalize it to '5' > '1'. After this PR, we normalize it to 5 > 1 to compatible with legacy planner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants