Skip to content

[Enhancement](optimize) optimize for function multiply on decimalv2 #13049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BiteTheDDDDt merged 4 commits into from
Oct 4, 2022
Merged

[Enhancement](optimize) optimize for function multiply on decimalv2 #13049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1ea8bc
optimize for function multiply on decimalv2
BiteTheDDDDt Sep 29, 2022
b36b328
update
BiteTheDDDDt Sep 29, 2022
e66f746
update
BiteTheDDDDt Sep 29, 2022
576f031
update
BiteTheDDDDt Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions be/src/vec/functions/function_binary_arithmetic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@

#pragma once

#include <type_traits>

#include "runtime/decimalv2_value.h"
#include "vec/columns/column_const.h"
#include "vec/columns/column_decimal.h"
#include "vec/columns/column_nullable.h"
Expand Down Expand Up @@ -241,9 +244,13 @@ struct DecimalBinaryOperation {
}
}

/// default: use it if no return before
for (size_t i = 0; i < size; ++i) {
c[i] = apply(a[i], b[i]);
if constexpr (OpTraits::is_multiply && std::is_same_v<A, Decimal128> &&
std::is_same_v<B, Decimal128>) {
Op::vector_vector(a, b, c);
} else {
for (size_t i = 0; i < size; i++) {
c[i] = apply(a[i], b[i]);
}
}
}

Expand Down
24 changes: 23 additions & 1 deletion be/src/vec/functions/multiply.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/Multiply.cpp
// and modified by Doris

#include "runtime/decimalv2_value.h"
#include "vec/columns/column_decimal.h"
#include "vec/common/arithmetic_overflow.h"
#include "vec/functions/function_binary_arithmetic.h"
#include "vec/functions/simple_function_factory.h"
Expand All @@ -35,9 +37,29 @@ struct MultiplyImpl {
}

template <typename Result = DecimalV2Value>
static inline DecimalV2Value apply(DecimalV2Value a, DecimalV2Value b) {
static inline DecimalV2Value apply(const DecimalV2Value& a, const DecimalV2Value& b) {
return a * b;
}

static void vector_vector(const ColumnDecimal128::Container& a,
const ColumnDecimal128::Container& b,
ColumnDecimal128::Container& c) {
size_t size = c.size();
int8 sgn[size];

for (int i = 0; i < size; i++) {
sgn[i] = ((DecimalV2Value(a[i]).value() >= 0) == (DecimalV2Value(b[i]).value() >= 0))
? 1
: -1;
}

for (int i = 0; i < size; i++) {
c[i] = (DecimalV2Value(a[i]).value() * DecimalV2Value(b[i]).value() - sgn[i]) /
DecimalV2Value::ONE_BILLION +
sgn[i];
}
}

/// Apply operation and check overflow. It's used for Deciamal operations. @returns true if overflowed, false otherwise.
template <typename Result = ResultType>
static inline bool apply(A a, B b, Result& c) {
Expand Down