Skip to content

[chore](be-ut) Remove useless lines which cause compilation errors#13053

Merged
dataroaring merged 1 commit intoapache:masterfrom
adonis0147:clang-15
Sep 30, 2022
Merged

[chore](be-ut) Remove useless lines which cause compilation errors#13053
dataroaring merged 1 commit intoapache:masterfrom
adonis0147:clang-15

Conversation

@adonis0147
Copy link
Copy Markdown
Contributor

@adonis0147 adonis0147 commented Sep 29, 2022

Proposed changes

Issue Number: close #xxx

Remove useless lines which cause compilation errors

Problem summary

Failed to build BE UT from source by clang-15.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 29, 2022
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Copy link
Copy Markdown
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit e7f18e9 into apache:master Sep 30, 2022
@adonis0147 adonis0147 deleted the clang-15 branch September 30, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants