Skip to content

[fix](rowset) fix that rowset writer doesn't process the return value , which may result in data loss#13189

Merged
dataroaring merged 1 commit intoapache:masterfrom
liaoxin01:fix_close
Oct 9, 2022
Merged

[fix](rowset) fix that rowset writer doesn't process the return value , which may result in data loss#13189
dataroaring merged 1 commit intoapache:masterfrom
liaoxin01:fix_close

Conversation

@liaoxin01
Copy link
Contributor

Proposed changes

Issue Number: close #13188

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2022

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

PR approved by at least one committer and no changes requested.

@yiguolei
Copy link
Contributor

yiguolei commented Oct 25, 2022

#13224

@liaoxin01 liaoxin01 deleted the fix_close branch November 14, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] failed to initialize storage reader. tablet=17764.1993551234.7745d334f645b261-bacfae93e6bebc83, res=Internal error(error -3109)

4 participants